shishkovilja commented on code in PR #12466:
URL: https://github.com/apache/ignite/pull/12466#discussion_r2473032226
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/task/GridTaskResultResponse.java:
##########
@@ -115,90 +111,33 @@ public void error(String err) {
}
/** {@inheritDoc} */
- @Override public boolean writeTo(ByteBuffer buf, MessageWriter writer) {
- writer.setBuffer(buf);
-
- if (!writer.isHeaderWritten()) {
- if (!writer.writeHeader(directType()))
- return false;
-
- writer.onHeaderWritten();
- }
-
- switch (writer.state()) {
- case 0:
- if (!writer.writeString(err))
- return false;
-
- writer.incrementState();
-
- case 1:
- if (!writer.writeBoolean(finished))
- return false;
-
- writer.incrementState();
-
- case 2:
- if (!writer.writeBoolean(found))
- return false;
-
- writer.incrementState();
-
- case 3:
- if (!writer.writeByteArray(resBytes))
- return false;
-
- writer.incrementState();
-
- }
-
- return true;
+ @Override public short directType() {
+ return 77;
}
- /** {@inheritDoc} */
- @Override public boolean readFrom(ByteBuffer buf, MessageReader reader) {
- reader.setBuffer(buf);
-
- switch (reader.state()) {
- case 0:
- err = reader.readString();
-
- if (!reader.isLastRead())
- return false;
-
- reader.incrementState();
-
- case 1:
- finished = reader.readBoolean();
-
- if (!reader.isLastRead())
- return false;
-
- reader.incrementState();
-
- case 2:
- found = reader.readBoolean();
-
- if (!reader.isLastRead())
- return false;
-
- reader.incrementState();
-
- case 3:
- resBytes = reader.readByteArray();
+ /**
+ * Marshals task result to byte array.
+ *
+ * @param ctx Context.
+ * @param res Task result.
+ */
+ public void marshalResult(GridKernalContext ctx, @Nullable Object res)
throws IgniteCheckedException {
+ this.res = res;
Review Comment:
Seems to be redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
