sanpwc commented on code in PR #6843:
URL: https://github.com/apache/ignite-3/pull/6843#discussion_r2480700277
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java:
##########
@@ -1239,6 +1239,15 @@ void onHeartbeatReturned(final ThreadId id, final Status
status, final AppendEnt
r.startHeartbeatTimer(startTimeMs);
return;
}
+ if (!response.success()) {
Review Comment:
if (!response.success() && response.lastLogIndex() != 0) {
fooBar();
}
if (!response.success()) {
fooBar();
}
We will call fooBar() twice if (!response.success() &&
response.lastLogIndex() != 0) which is not intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
