xtern commented on code in PR #6835: URL: https://github.com/apache/ignite-3/pull/6835#discussion_r2481614505
########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/DdlBatchingHelper.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.exec.fsm; + +import org.apache.calcite.sql.SqlNode; +import org.apache.ignite.internal.sql.engine.sql.ParsedResult; +import org.jetbrains.annotations.Nullable; + +/** + * Provide helper methods for batched DDL commands. + */ +public class DdlBatchingHelper { + /** + * Returns {@code true} if given statement is compatible with script statement. + * Node: the operation is not commutative. + */ + static boolean isCompatible(ParsedResult scriptStatement, ParsedResult statement) { + @Nullable DdlBatchGroup batchGroup = scriptStatement.ddlBatchGroup(); + @Nullable DdlBatchGroup statementGroup = statement.ddlBatchGroup(); + + if (batchGroup == null || statementGroup == null) { + // Actually, we should never get here, but I we missed smth, it is always safe to fallback to non-batched execution. Review Comment: ```suggestion // Actually, we should never get here, but If we missed smth, it is always safe to fallback to non-batched execution. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
