korlov42 commented on code in PR #6649:
URL: https://github.com/apache/ignite-3/pull/6649#discussion_r2510612551
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/message/ReplicaMessageGroup.java:
##########
@@ -60,4 +60,13 @@ public interface ReplicaMessageGroup {
/** Message type for {@link ZonePartitionIdMessage}. */
short ZONE_PARTITION_ID_MESSAGE = 43;
+
+ /** Message type for {@link GetEstimatedSizeWithLastModifiedTsRequest}. */
+ short GET_ESTIMATED_SIZE_WITH_MODIFIED_TS_MESSAGE_REQUEST = 44;
Review Comment:
let's move these messages either to table module or to sql
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/message/GetEstimatedSizeWithLastModifiedTsRequest.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.replicator.message;
+
+import java.util.Collection;
+import org.apache.ignite.internal.network.NetworkMessage;
+import org.apache.ignite.internal.network.annotations.Transferable;
+
+/** A message that queries a partition estimate size and last modification ts.
*/
+@Transferable(ReplicaMessageGroup.GET_ESTIMATED_SIZE_WITH_MODIFIED_TS_MESSAGE_REQUEST)
+public interface GetEstimatedSizeWithLastModifiedTsRequest extends
NetworkMessage {
+ /** Table id`s to request estimated size for. */
+ Collection<Integer> tables();
Review Comment:
`tables` seems to be not used. Let's remove this property
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/PartitionModificationInfo.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.replicator;
+
+/** Partition modification information holder. */
+public class PartitionModificationInfo {
Review Comment:
why is this part of replicator when it's used solely for statistic
aggregation which resides in SQL module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
