lowka opened a new pull request, #6934:
URL: https://github.com/apache/ignite-3/pull/6934

   Updates SQL exception mapping in CLI to include correct brief error 
description and traceId.
   Adds brief error description for all SQL errors, adds default ones to other 
ignite codes.
   
   ```
   sql-cli> SELEC 1;
   262147 Trace ID: 4a63b5f2-0b41-49b6-bda0-a17f94a40479
   SQL query parsing error                                                      
                                                                                
                                                                                
              
   IGN-SQL-3: Failed to parse query: Non-query expression encountered in 
illegal context. At line 1, column 1
   ```
   
   ```
   sql-cli> SELECT * FROM not_existing_table
   262148 Trace ID: 05be0a55-e97f-4b37-9aba-60fcbfc59722
   SQL query validation error                                                   
                                                                                
                                                                                
              
   IGN-SQL-4: Failed to validate query. From line 1, column 15 to line 1, 
column 32: Object 'NOT_EXISTING_TABLE' not found
   ```
   
   ```
   sql-cli> SELECT 1/0;
   262151 Trace ID: 32acd46b-d6d3-46f5-a152-e3ad1662f762
   SQL query execution error                                                    
                                                                                
                                                                                
              
   IGN-SQL-7: Division by zero
   ```
   
   https://issues.apache.org/jira/browse/IGNITE-26790
   
   ---
   
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE-XXXX Change summary where XXXX - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to