sanpwc commented on code in PR #6850:
URL: https://github.com/apache/ignite-3/pull/6850#discussion_r2513977205
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -3635,6 +3673,16 @@ public void changePeersAndLearners(final Configuration
newPeersAndLearners, long
return;
}
+ if (this.conf.getConf().getSequenceToken() >
newPeersAndLearners.getSequenceToken()) {
+ LOG.info("Node {} received stale configuration for conf {},
existing is {}, new {}.",
+ getNodeId(), newPeersAndLearners,
this.conf.getConf().getSequenceToken(),
newPeersAndLearners.getSequenceToken());
+ Status status =
staleConfiguration(newPeersAndLearners.getSequenceToken());
Review Comment:
What I mean here, is that generally (from the common sense point of view) in
order to overcome ESTALE error it's required to retry the operation in
assumption that server will become up-to-date, which is not the case here,
since in provided case the request is stale not the server that contradicts
with common practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
