korlov42 commented on code in PR #6927: URL: https://github.com/apache/ignite-3/pull/6927#discussion_r2513995358
########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/configuration/distributed/TablePropertiesConfigurationSchema.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.configuration.distributed; + +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.DEFAULT_MIN_STALE_ROWS_COUNT; +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.DEFAULT_STALE_ROWS_FRACTION; + +import org.apache.ignite.configuration.annotation.Config; +import org.apache.ignite.configuration.annotation.Value; +import org.apache.ignite.configuration.validation.Range; + +/** Configuration for table initialization properties. */ +@Config +public class TablePropertiesConfigurationSchema { Review Comment: nitpick: I would rename this to more abstract scope like `CreateTableDefaultsConfigurationSchema`. I envision like one might refuse to add new entries to this class just because it won't belong to _table properties_ ########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ########## @@ -287,7 +289,11 @@ public synchronized CompletableFuture<Void> startAsync(ComponentContext componen var storageProfileValidator = new ClusterWideStorageProfileValidator(logicalTopologyService); var nodeFilterValidator = new ClusterWideNodeFilterValidator(logicalTopologyService); - var ddlSqlToCommandConverter = new DdlSqlToCommandConverter(storageProfileValidator, nodeFilterValidator); + Supplier<TableStatsStalenessConfiguration> stalenessProperties = () -> new TableStatsStalenessConfiguration( + clusterCfg.createTable().staleRowsFraction().value(), + clusterCfg.createTable().minStaleRowsCount().value()); Review Comment: two invocation of `value()` returns two different views of configuration. In other words, this may result in properties combination which never exists (i.e. value of `staleRowsFraction` from one state and value of `minStaleRowsCount ` from another). It's better to get view from `createTable()` and then read necessary properties ########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverterTest.java: ########## @@ -114,7 +117,10 @@ public class DdlSqlToCommandConverterTest extends AbstractDdlSqlToCommandConvert @BeforeEach void setUp() { - converter = new DdlSqlToCommandConverter(storageProfiles -> completedFuture(null), filter -> completedFuture(null)); + Supplier<TableStatsStalenessConfiguration> statStalenessProperties = () -> new TableStatsStalenessConfiguration( + DEFAULT_STALE_ROWS_FRACTION, DEFAULT_MIN_STALE_ROWS_COUNT); + converter = new DdlSqlToCommandConverter(storageProfiles -> completedFuture(null), filter -> completedFuture(null), + statStalenessProperties); } Review Comment: please add tests to make sure `DdlSqlToCommandConverter` respects provided configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
