chesnokoff commented on code in PR #12513:
URL: https://github.com/apache/ignite/pull/12513#discussion_r2517889844
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/RollingUpgradeProcessor.java:
##########
@@ -278,32 +299,20 @@ public boolean enabled() {
*
* @param cur Current cluster version.
* @param target Target cluster version.
- * @return {@code false} if there is no need to update versions {@code
true} otherwise.
* @throws IgniteCheckedException If versions are incorrect.
*/
- private boolean checkVersionsForEnabling(IgniteProductVersion cur,
IgniteProductVersion target) throws IgniteCheckedException {
- IgnitePair<IgniteProductVersion> oldVerPair = rollUpVers;
- if (oldVerPair != null) {
- if (oldVerPair.get1().equals(cur) &&
oldVerPair.get2().equals(target))
- return false;
-
- throw new IgniteCheckedException("Rolling upgrade is already
enabled with a different current and target version: " +
- oldVerPair.get1() + " , " + oldVerPair.get2());
- }
-
Review Comment:
move this out of checkVersionsForEnabling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
