tkalkirill commented on code in PR #6951:
URL: https://github.com/apache/ignite-3/pull/6951#discussion_r2521607899
##########
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/store/AbstractFilePageStoreIoTest.java:
##########
@@ -405,6 +404,6 @@ void testRenameAndReadRace(FileIoFactory ioFactory) throws
Exception {
}
private static FileIoFactory[] ioFactories() {
- return new FileIoFactory[]{new RandomAccessFileIoFactory(), new
AsyncFileIoFactory()};
+ return new FileIoFactory[]{new RandomAccessFileIoFactory()};
Review Comment:
I think it's worth returning to the way it was, because we can return to a
different implementation.
##########
modules/runner/src/test/resources/compatibility/configuration/ignite-snapshot.bin:
##########
Review Comment:
What has changed here?
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryStorageEngine.java:
##########
@@ -184,9 +183,7 @@ public void start() throws StorageException {
int pageSize = engineConfig.pageSizeBytes().value();
try {
- FileIoFactory fileIoFactory =
engineConfig.checkpoint().useAsyncFileIoFactory().value()
- ? new AsyncFileIoFactory()
- : new RandomAccessFileIoFactory();
+ FileIoFactory fileIoFactory = new RandomAccessFileIoFactory();
Review Comment:
```suggestion
var fileIoFactory = new RandomAccessFileIoFactory();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
