ptupitsyn commented on code in PR #6779:
URL: https://github.com/apache/ignite-3/pull/6779#discussion_r2533567864
##########
modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTable.java:
##########
@@ -762,16 +796,24 @@ private static <E> void reduceWithKeepOrder(List<E> agg,
List<E> cur, List<Integ
}
}
- <R, E> CompletableFuture<R> split(
- Transaction tx,
+ <R, E> CompletableFuture<R> splitAndRun(
Collection<E> keys,
- BiFunction<Collection<E>, PartitionAwarenessProvider,
CompletableFuture<R>> fun,
+ MapFunction<E, R> fun,
@Nullable R initialValue,
Reducer<R> reducer,
BiFunction<ClientSchema, E, Integer> hashFunc
) {
- assert tx != null;
+ return splitAndRun(keys, fun, initialValue, reducer, hashFunc,
List.of());
Review Comment:
> 99.99% of time we will have full connectivity
Not really, a common use case is to connect to the cluster through a proxy
> splitting is always need to be performed - either server or client side
That is true, but again, sending one batch to the cluster and splitting on
the server might be faster.
I don't insist, we can optimize this later if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
