ptupitsyn commented on code in PR #6971:
URL: https://github.com/apache/ignite-3/pull/6971#discussion_r2537728049
##########
modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -207,6 +207,9 @@ public static class Common {
* should be considered as a non-recoverable error
*/
public static final int INTERNAL_ERR =
COMMON_ERR_GROUP.registerErrorCode((short) 0xFFFF);
+
+ /** This error code indicates that a node is attempting to start over
an unsupported table based replication mode. */
+ public static final int UNSUPPORTED_TABLE_BASED_REPLICATION_ERR =
COMMON_ERR_GROUP.registerErrorCode((short) 10);
Review Comment:
```suggestion
/** This error code indicates that a node is attempting to start
over an unsupported table based replication mode. */
public static final int UNSUPPORTED_TABLE_BASED_REPLICATION_ERR =
COMMON_ERR_GROUP.registerErrorCode((short) 10);
/**
* This error code represents an internal error caused by faulty
logic or coding in the Ignite codebase. In general, this error code
* should be considered as a non-recoverable error
*/
public static final int INTERNAL_ERR =
COMMON_ERR_GROUP.registerErrorCode((short) 0xFFFF);
```
##########
modules/compatibility-tests/src/testFixtures/resources/igniteVersions.json:
##########
@@ -16,9 +16,6 @@
"ignite.storage.profiles.default.size": 268435456
},
"versions": [
- {
- "version": "3.0.0"
- },
Review Comment:
Broken compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
