xtern commented on code in PR #7007: URL: https://github.com/apache/ignite-3/pull/7007#discussion_r2541435596
########## modules/jdbc/src/integrationTest/java/org/apache/ignite/jdbc/ItJdbcConnectionFailoverTest.java: ########## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.jdbc; + +import static org.apache.ignite.internal.testframework.IgniteTestUtils.assertThrows; +import static org.awaitility.Awaitility.await; +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.MatcherAssert.assertThat; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.time.Duration; +import java.util.stream.Collectors; +import java.util.stream.IntStream; +import org.apache.ignite.internal.ClusterPerTestIntegrationTest; +import org.apache.ignite.internal.jdbc2.JdbcConnection2; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.Test; + +/** + * Basic test scenarios with JDBC connection failover. + */ +public class ItJdbcConnectionFailoverTest extends ClusterPerTestIntegrationTest { + private static final int BASE_CLIENT_PORT = 10800; + + @Override + protected int initialNodes() { + return 0; + } + + @Test + void testMultipleConnectionEstablishment() throws SQLException { + int nodesCount = 2; + + cluster.startAndInit(nodesCount, new int[]{0}); + + try (Connection connection = getConnection(nodesCount)) { + await().timeout(Duration.ofSeconds(5)) + .until(() -> channelsCount(connection), is(nodesCount)); + } + } + + /** + * Ensures that the query is forwarded to the alive node. + * + * <p>Test sequentially restarts each cluster node keeping CMG majority alive. + */ + @Test + void testConnectionFailover() throws SQLException { + int nodesCount = 3; + cluster.startAndInit(nodesCount, new int[]{0, 1, 2}); + + try (Connection connection = getConnection(nodesCount)) { + try (Statement stmt = connection.createStatement()) { + stmt.executeUpdate("CREATE ZONE zone1 (REPLICAS 3, PARTITIONS 1) STORAGE PROFILES ['default']"); + stmt.executeUpdate("CREATE TABLE t(id INT PRIMARY KEY, val INT) ZONE zone1"); + assertThat(stmt.executeUpdate("INSERT INTO t VALUES (1, 1)"), is(1)); + + cluster.stopNode(0); + assertThat(stmt.executeUpdate("INSERT INTO t VALUES (2, 2)"), is(1)); + + cluster.startNode(0); + cluster.stopNode(1); + assertThat(stmt.executeUpdate("INSERT INTO t VALUES (3, 3)"), is(1)); + + cluster.startNode(1); + cluster.stopNode(2); + assertThat(stmt.executeUpdate("INSERT INTO t VALUES (4, 4)"), is(1)); + + ResultSet rs = stmt.executeQuery("SELECT COUNT(*) FROM t WHERE id > 0"); + assertThat(rs.next(), is(true)); + assertThat(rs.getInt(1), is(4)); + } + } + } + + /** + * Checks transparent connection establishment after losing all connections. + */ + @Test + void testTotalConnectionFailover() throws SQLException { + int nodesCount = 3; + cluster.startAndInit(nodesCount, new int[]{2}); + String dummyQuery = "SELECT 1"; + + try (Connection connection = getConnection(nodesCount - 1)) { + try (Statement stmt = connection.createStatement()) { + assertThat(stmt.execute(dummyQuery), is(true)); + + // Stop all cluster nodes known to the client. + cluster.stopNode(0); + cluster.stopNode(1); + + //noinspection ThrowableNotThrown + assertThrows( + SQLException.class, + () -> stmt.execute("SELECT 1"), + "Connection refused" + ); + + cluster.startNode(1); + + assertThat(stmt.execute("SELECT 1"), is(true)); + } + } + } + + @Test + @Disabled("https://issues.apache.org/jira/browse/IGNITE-27091";) + void testTransactionCannotBeUsedAfterNodeRestart() throws SQLException { Review Comment: Currently, this test only fails on the last line—an attempt to rollback a transaction while closing the statement throws "channel is closed." The fix seems trivial, but during a private discussion, it was decided to address this in a separate ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
