xtern commented on code in PR #7010:
URL: https://github.com/apache/ignite-3/pull/7010#discussion_r2541562982
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/CursorInitializationPhaseHandler.java:
##########
@@ -46,7 +47,13 @@ public Result handle(Query query) {
CompletableFuture<Void> awaitFuture =
query.executor.executePlan(context, plan)
.thenCompose(dataCursor -> {
- AsyncSqlCursor<InternalSqlRow> cursor =
query.executor.createAndSaveSqlCursor(query, dataCursor);
+ AsyncSqlCursor<InternalSqlRow> cursor;
+ try {
+ cursor = query.executor.createAndSaveSqlCursor(query,
dataCursor);
Review Comment:
As I see `createAndSaveSqlCursor` also used when processing batch of ddl
statements from script (see `QueryExecutor.executeChildBatch`).
I'm not sure, but it seems there is a chance that the query could hang if an
exception occurs in the same method.
Should we handle query cancellation exception there also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
