korlov42 commented on code in PR #6968:
URL: https://github.com/apache/ignite-3/pull/6968#discussion_r2541736917
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/RowHandler.java:
##########
@@ -63,7 +63,7 @@ default ByteBuffer toByteBuffer(RowT row) {
String toString(RowT row);
/** Creates a factory that produces rows with fields defined by the given
schema. */
- RowFactory<RowT> factory(RowSchema rowSchema);
+ RowFactory<RowT> factory(StructNativeType rowSchema);
Review Comment:
we still use `schema` in the context of describing row layout (see
`SchemaDescriptor`), thus I think it's ok to leave variable name as `rowSchema`
(it's not an arbitrary structured type, it's descriptor (i.e. schema) of the
tuple created by this factory).
Moreover, rename like this will generate gazillion of changes which (in my
opinion) doesn't bring anything to the project.
But if you strongly believe it would be better to have matching name, I will
do rename
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
