arcolight commented on code in PR #7001:
URL: https://github.com/apache/ignite-3/pull/7001#discussion_r2549467725
##########
modules/platforms/cpp/ignite/odbc/config/configuration.h:
##########
@@ -57,6 +57,9 @@ class configuration {
/** Default value for SSL mode. */
static inline const ssl_mode_t ssl_mode{ssl_mode_t::DISABLE};
+
+ /** Default heartbeat interval. */
+ static inline const std::chrono::milliseconds
heartbeat_interval{std::chrono::milliseconds{2000}};
Review Comment:
Right, I used interval from tests. Fixed.
##########
modules/platforms/cpp/ignite/odbc/odbc.cpp:
##########
@@ -83,15 +83,17 @@ const char *attr_id_to_string(uint16_t id) {
namespace ignite {
+using sql_connection_ptr = sql_environment::sql_connection_ptr;
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
