sanpwc commented on code in PR #7028:
URL: https://github.com/apache/ignite-3/pull/7028#discussion_r2549536299
##########
modules/index/src/test/java/org/apache/ignite/internal/index/ChangeIndexStatusTaskTest.java:
##########
@@ -367,7 +365,7 @@ private CatalogIndexStatus actualIndexStatus() {
}
private ReplicaMeta createLocalNodeReplicaMeta(HybridTimestamp startTime,
HybridTimestamp expirationTime) {
- return newPrimaryReplicaMeta(LOCAL_NODE, new
TablePartitionId(indexDescriptor.tableId(), 0), startTime, expirationTime);
+ return newPrimaryReplicaMeta(LOCAL_NODE, new ZonePartitionId(0, 0),
startTime, expirationTime);
Review Comment:
Here and below.
Is it safe to use 0 as zone descriptor here. I do understand that tests
pass, however it might be a bit more robust to retrieve zoneId from the
catalog, something like:
```
assert
catalogManager.catalog(catalogManager.latestCatalogVersion()).zones().size() ==
1;
var zoneId =
catalogManager.catalog(catalogManager.latestCatalogVersion()).zones().iterator().next().id();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
