chesnokoff commented on code in PR #12522:
URL: https://github.com/apache/ignite/pull/12522#discussion_r2555502972
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/RollingUpgradeProcessor.java:
##########
@@ -320,4 +328,31 @@ private boolean checkVersionsForEnabling(
return true;
}
+
+ /** */
+ private GridLocalEventListener discoListener() {
+ return new GridLocalEventListener() {
+ @Override public void onEvent(Event evt) {
+ assert evt instanceof DiscoveryEvent;
+
+ assert evt.type() == EVT_NODE_LEFT || evt.type() ==
EVT_NODE_FAILED;
Review Comment:
I had a hypothesis that there might be a gap between sending the
`EVT_NODE_JOINED` event and the moment when the joining node is added to the
ring. In that case, rolling upgrade could be disabled while a node with a
different version is still joining.
However, `ServerImpl.RingMessageWorker#processNodeAddFinishedMessage` checks
that the ring already contains the node before sending `EVT_NODE_JOINED`, so
this situation cannot occur and this part works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
