sk0x50 commented on code in PR #7025:
URL: https://github.com/apache/ignite-3/pull/7025#discussion_r2555864385
##########
check-rules/spotbugs-excludes.xml:
##########
@@ -254,7 +254,6 @@
<Match>
<!-- I literally have no idea why these checks fail. -->
<Bug pattern="MS_PKGPROTECT"/>
- <Class
name="org.apache.ignite.internal.distributionzones.rebalance.RebalanceUtil"/>
Review Comment:
It seems to me that the whole matcher should be removed, right?
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngineV2.java:
##########
@@ -122,7 +126,11 @@ protected CompletableFuture<Void>
onReplicasUpdate(AlterZoneEventParameters para
long recoveryRevision = recoveryFinishFuture.join().revision();
- return recoveryRebalanceTrigger(recoveryRevision);
+ if (getBoolean(SKIP_REBALANCE_TRIGGERS_RECOVERY, false)) {
Review Comment:
Minor: does it make sense to introduce an internal field instead of
re-reading this flag every time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
