timoninmaxim commented on code in PR #12528:
URL: https://github.com/apache/ignite/pull/12528#discussion_r2557263499
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/BinaryWriterEx.java:
##########
@@ -29,6 +29,9 @@
* Extended writer interface.
*/
public interface BinaryWriterEx extends BinaryWriter, BinaryRawWriter,
ObjectOutput {
+ /** Default value for {@link #failIfUnregistered()}. */
+ public static final boolean DFLT_FAIL_IF_UNREGISTERED = false;
Review Comment:
I suppose it should be defined in BinaryWriterExImpl.
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java:
##########
@@ -2923,10 +2924,16 @@ static BinaryReaderEx reader(BinaryContext ctx,
* @param ctx Context.
* @return Writer instance.
*/
- public static BinaryWriterEx writer(BinaryContext ctx) {
+ public static BinaryWriterEx writer(BinaryContext ctx, boolean
failIfUnregistered) {
Review Comment:
add param to javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
