ibessonov commented on code in PR #7054: URL: https://github.com/apache/ignite-3/pull/7054#discussion_r2559499386
########## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/LogStorageAccess.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.partition.replicator.raft.snapshot; + +import org.apache.ignite.internal.replicator.ReplicationGroupId; + +/** Small abstraction for accessing the replication log. */ +public interface LogStorageAccess { + /** + * Destroys the replication log. + * + * @param replicationGroupId Replication group ID. + * @param isVolatile Is storage volatile. + * @throws Exception If there was an error during destruction. Review Comment: Plain `Exception` doesn't look like a good choice, can we be more specific? If not - please explain this choice, thank you! ########## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/LogStorageAccess.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.partition.replicator.raft.snapshot; + +import org.apache.ignite.internal.replicator.ReplicationGroupId; + +/** Small abstraction for accessing the replication log. */ +public interface LogStorageAccess { + /** + * Destroys the replication log. + * + * @param replicationGroupId Replication group ID. + * @param isVolatile Is storage volatile. + * @throws Exception If there was an error during destruction. + */ + void destroy(ReplicationGroupId replicationGroupId, boolean isVolatile) throws Exception; Review Comment: Can log storage itself determine that it's volatile? I don't think that we need to pass this flag, but maybe I'm wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
