Copilot commented on code in PR #7070: URL: https://github.com/apache/ignite-3/pull/7070#discussion_r2559802291
########## modules/platforms/dotnet/Apache.Extensions.Caching.Ignite/README.md: ########## @@ -14,13 +14,13 @@ services ``` * `AddIgniteClientGroup` is required for the cache to work. It is used to create a connection to the Ignite cluster. -* Ignite table will be created automatically if it does not exist. Key column is `VARCHAR` and value column is `VARBINARY`. +* Ignite table will be created automatically if it does not exist, with columns: `KEY VARCHAR PRIMARY KEY, VAL VARBINARY`. Review Comment: [nitpick] The documentation mentions only `KEY VARCHAR PRIMARY KEY, VAL VARBINARY`, but the actual table creation (in `IgniteDistributedCache.cs` lines 222-227) also includes `EXPIRATION BIGINT` and `SLIDING_EXPIRATION BIGINT` columns. Consider adding a note that additional internal columns are created for expiration management to provide complete information about the table structure. ```suggestion * Ignite table will be created automatically if it does not exist, with columns: `KEY VARCHAR PRIMARY KEY, VAL VARBINARY`, plus internal columns for expiration management: `EXPIRATION BIGINT`, `SLIDING_EXPIRATION BIGINT`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
