ac1d0globlya commented on code in PR #12532:
URL: https://github.com/apache/ignite/pull/12532#discussion_r2580284698
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/BinaryWriterExImpl.java:
##########
@@ -61,29 +61,29 @@ class BinaryWriterExImpl implements BinaryWriterEx {
/** Schema. */
private final BinaryWriterSchemaHolder schema;
+ /** */
+ private final boolean failIfUnregistered;
Review Comment:
I grouped final and non final variables together just to make it more
readable.
Yes, we can revert grouping easily, but, looks like having all changing
state together more reliable way to list class variabled.
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/BinaryWriterExImpl.java:
##########
@@ -61,29 +61,29 @@ class BinaryWriterExImpl implements BinaryWriterEx {
/** Schema. */
private final BinaryWriterSchemaHolder schema;
+ /** */
+ private final boolean failIfUnregistered;
Review Comment:
I grouped final and non final variables together just to make it more
readable.
Yes, we can revert grouping easily, but, looks like having all changing
state together more reliable way to list class variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
