Copilot commented on code in PR #7148:
URL: https://github.com/apache/ignite-3/pull/7148#discussion_r2588793989
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/ConnectionPropertiesImpl.java:
##########
@@ -59,17 +59,28 @@ public class ConnectionPropertiesImpl implements
ConnectionProperties, Serializa
"Schema name of the connection", "PUBLIC", null, false, null);
/** Query timeout. */
- private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeout",
+ private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeoutSeconds",
"Sets the number of seconds the driver will wait for a
<code>Statement</code> object to execute."
+ " Zero means there is no limits.",
- null, false, 0, Integer.MAX_VALUE);
+ 0, false, 0, Integer.MAX_VALUE);
- /** JDBC connection timeout. */
+ /**
+ * JDBC connection timeout.
+ *
+ * @deprecated Use {@link #connTimeoutMillis} instead.
+ */
+ @Deprecated
private final IntegerProperty connTimeout = new
IntegerProperty("connectionTimeout",
"Sets the number of milliseconds JDBC client will waits for server
to response."
+ " Zero means there is no limits.",
0L, false, 0, Integer.MAX_VALUE);
+ /** JDBC connection timeout. */
+ private final IntegerProperty connTimeoutMillis = new
IntegerProperty("connectionTimeoutMillis",
+ "Sets the number of milliseconds JDBC client will waits for server
to response."
Review Comment:
Grammar error: "will waits" should be "will wait".
```suggestion
"Sets the number of milliseconds JDBC client will wait for
server to response."
+ " Zero means there is no limits.",
0L, false, 0, Integer.MAX_VALUE);
/** JDBC connection timeout. */
private final IntegerProperty connTimeoutMillis = new
IntegerProperty("connectionTimeoutMillis",
"Sets the number of milliseconds JDBC client will wait for
server to response."
```
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/ConnectionPropertiesImpl.java:
##########
@@ -59,17 +59,28 @@ public class ConnectionPropertiesImpl implements
ConnectionProperties, Serializa
"Schema name of the connection", "PUBLIC", null, false, null);
/** Query timeout. */
- private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeout",
+ private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeoutSeconds",
"Sets the number of seconds the driver will wait for a
<code>Statement</code> object to execute."
+ " Zero means there is no limits.",
- null, false, 0, Integer.MAX_VALUE);
+ 0, false, 0, Integer.MAX_VALUE);
- /** JDBC connection timeout. */
+ /**
+ * JDBC connection timeout.
+ *
+ * @deprecated Use {@link #connTimeoutMillis} instead.
+ */
+ @Deprecated
private final IntegerProperty connTimeout = new
IntegerProperty("connectionTimeout",
"Sets the number of milliseconds JDBC client will waits for server
to response."
+ " Zero means there is no limits.",
0L, false, 0, Integer.MAX_VALUE);
+ /** JDBC connection timeout. */
+ private final IntegerProperty connTimeoutMillis = new
IntegerProperty("connectionTimeoutMillis",
+ "Sets the number of milliseconds JDBC client will waits for server
to response."
Review Comment:
Grammar error: "to response" should be "to respond".
```suggestion
"Sets the number of milliseconds JDBC client will waits for
server to respond."
+ " Zero means there is no limits.",
0L, false, 0, Integer.MAX_VALUE);
/** JDBC connection timeout. */
private final IntegerProperty connTimeoutMillis = new
IntegerProperty("connectionTimeoutMillis",
"Sets the number of milliseconds JDBC client will waits for
server to respond."
```
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/ConnectionPropertiesImpl.java:
##########
@@ -59,17 +59,28 @@ public class ConnectionPropertiesImpl implements
ConnectionProperties, Serializa
"Schema name of the connection", "PUBLIC", null, false, null);
/** Query timeout. */
- private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeout",
+ private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeoutSeconds",
"Sets the number of seconds the driver will wait for a
<code>Statement</code> object to execute."
+ " Zero means there is no limits.",
- null, false, 0, Integer.MAX_VALUE);
+ 0, false, 0, Integer.MAX_VALUE);
- /** JDBC connection timeout. */
+ /**
+ * JDBC connection timeout.
+ *
+ * @deprecated Use {@link #connTimeoutMillis} instead.
+ */
+ @Deprecated
private final IntegerProperty connTimeout = new
IntegerProperty("connectionTimeout",
"Sets the number of milliseconds JDBC client will waits for server
to response."
+ " Zero means there is no limits.",
0L, false, 0, Integer.MAX_VALUE);
+ /** JDBC connection timeout. */
+ private final IntegerProperty connTimeoutMillis = new
IntegerProperty("connectionTimeoutMillis",
+ "Sets the number of milliseconds JDBC client will waits for server
to response."
Review Comment:
Grammar error: "to response" should be "to respond".
```suggestion
"Sets the number of milliseconds JDBC client will wait for
server to respond."
+ " Zero means there is no limits.",
0L, false, 0, Integer.MAX_VALUE);
/** JDBC connection timeout. */
private final IntegerProperty connTimeoutMillis = new
IntegerProperty("connectionTimeoutMillis",
"Sets the number of milliseconds JDBC client will wait for
server to respond."
```
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/ConnectionPropertiesImpl.java:
##########
@@ -59,17 +59,28 @@ public class ConnectionPropertiesImpl implements
ConnectionProperties, Serializa
"Schema name of the connection", "PUBLIC", null, false, null);
/** Query timeout. */
- private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeout",
+ private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeoutSeconds",
"Sets the number of seconds the driver will wait for a
<code>Statement</code> object to execute."
+ " Zero means there is no limits.",
- null, false, 0, Integer.MAX_VALUE);
+ 0, false, 0, Integer.MAX_VALUE);
- /** JDBC connection timeout. */
+ /**
+ * JDBC connection timeout.
+ *
+ * @deprecated Use {@link #connTimeoutMillis} instead.
+ */
+ @Deprecated
private final IntegerProperty connTimeout = new
IntegerProperty("connectionTimeout",
"Sets the number of milliseconds JDBC client will waits for server
to response."
+ " Zero means there is no limits.",
0L, false, 0, Integer.MAX_VALUE);
+ /** JDBC connection timeout. */
+ private final IntegerProperty connTimeoutMillis = new
IntegerProperty("connectionTimeoutMillis",
+ "Sets the number of milliseconds JDBC client will waits for server
to response."
Review Comment:
Grammar error: "will waits" should be "will wait".
```suggestion
"Sets the number of milliseconds JDBC client will wait for
server to response."
+ " Zero means there is no limits.",
0L, false, 0, Integer.MAX_VALUE);
/** JDBC connection timeout. */
private final IntegerProperty connTimeoutMillis = new
IntegerProperty("connectionTimeoutMillis",
"Sets the number of milliseconds JDBC client will wait for
server to response."
```
##########
modules/jdbc/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java:
##########
@@ -110,7 +110,7 @@
* <th colspan="2">Connection properties</th>
* </tr>
* <tr>
- * <td>connectionTimeout</td>
+ * <td>connectionTimeoutMillis</td>
* <td>Number of milliseconds JDBC client will waits for server to
response. Zero means there is no limits.
Review Comment:
Grammar error: "will waits" should be "will wait".
```suggestion
* <td>Number of milliseconds JDBC client will wait for server to
respond. Zero means there is no limits.
```
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/ConnectionPropertiesImpl.java:
##########
@@ -59,17 +59,28 @@ public class ConnectionPropertiesImpl implements
ConnectionProperties, Serializa
"Schema name of the connection", "PUBLIC", null, false, null);
/** Query timeout. */
- private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeout",
+ private final IntegerProperty qryTimeout = new
IntegerProperty("queryTimeoutSeconds",
"Sets the number of seconds the driver will wait for a
<code>Statement</code> object to execute."
+ " Zero means there is no limits.",
- null, false, 0, Integer.MAX_VALUE);
+ 0, false, 0, Integer.MAX_VALUE);
Review Comment:
Breaking change: The property name has been changed from "queryTimeout" to
"queryTimeoutSeconds" without maintaining backward compatibility. Unlike
"connectionTimeout" which has a deprecated property for backward compatibility
(lines 73-76), there is no deprecated "queryTimeout" property. This means
existing applications using "queryTimeout" in their connection strings will no
longer work. Consider adding a deprecated "queryTimeout" property similar to
how "connectionTimeout" is handled for backward compatibility.
##########
modules/jdbc/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java:
##########
@@ -110,7 +110,7 @@
* <th colspan="2">Connection properties</th>
* </tr>
* <tr>
- * <td>connectionTimeout</td>
+ * <td>connectionTimeoutMillis</td>
* <td>Number of milliseconds JDBC client will waits for server to
response. Zero means there is no limits.
Review Comment:
Grammar error: "to response" should be "to respond".
```suggestion
* <td>Number of milliseconds JDBC client will waits for server to
respond. Zero means there is no limits.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
