isapego commented on code in PR #7080:
URL: https://github.com/apache/ignite-3/pull/7080#discussion_r2589530574
##########
modules/platforms/cpp/ignite/client/detail/node_connection.cpp:
##########
@@ -203,7 +208,46 @@ std::shared_ptr<response_handler>
node_connection::find_handler_unsafe(std::int6
if (it == m_request_handlers.end())
return {};
- return it->second;
+ return it->second.handler;
+}
+
+void node_connection::handle_timeouts() {
+ auto now = std::chrono::steady_clock::now();
+
+ {
+ std::lock_guard lock(m_request_handlers_mutex);
+
+ std::vector<int64_t> keys_for_erasure;
Review Comment:
Is it?
##########
modules/platforms/cpp/ignite/client/detail/node_connection.cpp:
##########
@@ -203,7 +208,46 @@ std::shared_ptr<response_handler>
node_connection::find_handler_unsafe(std::int6
if (it == m_request_handlers.end())
return {};
- return it->second;
+ return it->second.handler;
+}
+
+void node_connection::handle_timeouts() {
+ auto now = std::chrono::steady_clock::now();
+
+ {
+ std::lock_guard lock(m_request_handlers_mutex);
+
+ std::vector<int64_t> keys_for_erasure;
+
+ for (auto& [id, req] : m_request_handlers) {
+ if (req.timeouts_at > now) {
Review Comment:
Have you pushed the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
