EgorKuts commented on code in PR #7155:
URL: https://github.com/apache/ignite-3/pull/7155#discussion_r2598591303
##########
modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java:
##########
@@ -366,21 +369,31 @@ Publisher<BinaryRow> scan(
);
/**
- * Scans given partition index, providing {@link Publisher} that
reactively notifies about partition rows.
+ * Scans given partition within a read-write transaction with explicit
index and range criteria specification, providing
+ * {@link Publisher} that reactively notifies about partition rows.
+ *
+ * <p>This method extends the basic scan operation by accepting additional
parameters:
+ * <ul>
+ * <li>{@code indexId} - specifies which index to use for the scan
operation. This enables the scan to leverage index structures
+ * (hash or sorted) for data retrieval.</li>
+ * <li>{@code criteria} - defines range boundaries (lower/upper bounds
and flags) to filter the rows returned by the scan.</li>
+ * </ul>
+ *
+ * <p>Use this method when you need to control which index is used or when
you need to apply range filtering to limit the result set.
+ * For simple scans without these requirements, {@link #scan(int,
InternalTransaction)} provides a simpler interface.
*
* @param partId The partition.
* @param tx The transaction.
- * @param indexId Index id.
- * @param criteria Index scan criteria.
- * @return {@link Publisher} that reactively notifies about partition rows.
+ * @param indexId Index id to use for the scan operation.
+ * @param criteria Range criteria defining the lower and upper bounds for
filtering rows.
+ * @return {@link Publisher} that reactively notifies about partition rows
matching the criteria.
+ * @throws TransactionException If proposed {@code tx} is read-only.
+ * @see #scan(int, InternalTransaction)
*/
- // TODO: https://issues.apache.org/jira/browse/IGNITE-26846 Drop the
method.
- @TestOnly
- @Deprecated(forRemoval = true)
Publisher<BinaryRow> scan(
int partId,
@Nullable InternalTransaction tx,
- int indexId,
+ Integer indexId,
Review Comment:
added a special assert for that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
