tkalkirill commented on code in PR #7185:
URL: https://github.com/apache/ignite-3/pull/7185#discussion_r2601107394
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflow.java:
##########
@@ -209,6 +209,8 @@ public Checkpoint markCheckpointBegin(
AwaitTasksCompletionExecutor executor = callbackListenerThreadPool ==
null
? null : new
AwaitTasksCompletionExecutor(callbackListenerThreadPool, updateHeartbeat);
+ tracker.onBeforeCheckpointBeginStart();
Review Comment:
`checkpointReadWriteLock.readLock();` can take a long time.
Let's add this code below right before the loop.
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflow.java:
##########
@@ -229,6 +231,8 @@ public Checkpoint markCheckpointBegin(
checkpointReadWriteLock.readUnlock();
}
+ tracker.onBeforeCheckpointBeginEnd();
Review Comment:
I suggest moving this line immediately after waiting for tasks to complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
