ibessonov commented on code in PR #7191:
URL: https://github.com/apache/ignite-3/pull/7191#discussion_r2605564574
##########
modules/network/src/test/java/org/apache/ignite/internal/network/recovery/RecoveryAcceptorHandshakeManagerTest.java:
##########
@@ -102,6 +103,9 @@ class RecoveryAcceptorHandshakeManagerTest extends
HandshakeManagerTest {
@Captor
private ArgumentCaptor<OutNetworkObject> sentMessageCaptor;
+ @Mock
+ protected TopologyService topologyService;
Review Comment:
For some of them there's a clear intent. For example, methods like
`newRecovery*HandshakeManager` there's an intended virtual method that works
like a factory method, and all the fields that it uses are marked `protected`
now, so that a subclasses can use all the same arguments for the managers that
they instantiate. But this in particular - I agree, I did that automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
