alievmirza commented on code in PR #7220:
URL: https://github.com/apache/ignite-3/pull/7220#discussion_r2613482888
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -1220,11 +1220,6 @@ private CompletableFuture<Void> updatePartitionClients(
return nullCompletedFuture();
}
- assert replicaMgr.isReplicaStarted(zonePartitionId)
Review Comment:
this method is called only from `handleChangeStableAssignmentEvent`, and it
is possible that during rebalance replica could be restarted, (meaning, during
`handleChangeStableAssignmentEvent`) so this assert is not correct, because
`isReplicaStarted` checks that future is already completed, but actually
replica can be in restarting proccess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
