xtern commented on code in PR #7206:
URL: https://github.com/apache/ignite-3/pull/7206#discussion_r2618535469
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/statistic/ItStatisticTest.java:
##########
@@ -122,15 +117,15 @@ public void testTableSizeUpdatesForcibly() {
sqlStatisticManager.lastUpdateStatisticFuture().join();
// query not cached in plans
- Awaitility.await().pollInterval(Duration.ofMillis(pollInterval))
- .timeout(timeout, TimeUnit.MILLISECONDS).untilAsserted(() -> {
- sqlStatisticManager.forceUpdateAll();
- sqlStatisticManager.lastUpdateStatisticFuture().join();
-
- assertQuery("select 1 from t")
- .matches(nodeRowCount("TableScan", is((int)
updates2)))
- .check();
- }
+ Awaitility.await().pollInterval(REFRESH_POLL_INTERVAL)
+ .timeout(REFRESH_CHECK_TIMEOUT).untilAsserted(() -> {
+ sqlStatisticManager.forceUpdateAll();
Review Comment:
How does this call affect the test's behavior? As far as I can tell, even if
I remove it, the test still passes.
Perhaps we don't need busy wait here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
