Vladsz83 commented on code in PR #12581:
URL: https://github.com/apache/ignite/pull/12581#discussion_r2619272497
##########
modules/core/src/main/java/org/apache/ignite/internal/IgniteDiagnosticRequest.java:
##########
@@ -142,13 +143,13 @@ public void futureId(long futId) {
}
/** @return Compound diagnostic infos. */
- public @Nullable Collection<DiagnosticBaseInfo> infos() {
+ public @Nullable LinkedHashSet<DiagnosticBaseInfo> infos() {
return infos;
}
/** Sets compound diagnostic infos. */
- public void infos(@Nullable Collection<DiagnosticBaseInfo> infos) {
- // Deserialization supports only `Collection` interface in
MessageReader#readCollection.
+ public void infos(@Nullable Set<DiagnosticBaseInfo> infos) {
Review Comment:
Witout this change, compilation error appears:
`IgniteDiagnosticRequestSerializer.java:[89,20] incompatible types: inferred
type does not conform to upper bound(s)
[ERROR] inferred:
java.lang.Object&java.util.Set<?>&java.util.Collection<org.apache.ignite.internal.IgniteDiagnosticRequest.DiagnosticBaseInfo>
[ERROR] upper bound(s):
java.util.Collection<org.apache.ignite.internal.IgniteDiagnosticRequest.DiagnosticBaseInfo>,java.util.Set<?>
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
