shishkovilja commented on code in PR #12568:
URL: https://github.com/apache/ignite/pull/12568#discussion_r2622171920
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeRequest.java:
##########
@@ -67,7 +79,7 @@ public UUID checkPreviousNodeId() {
*
* @param prevNodeId If not {@code null}, will set topology check flag and
set node ID to check.
*/
- public void changeTopology(UUID prevNodeId) {
+ public void previousNodeId(@Nullable UUID prevNodeId) {
setFlag(CHANGE_TOPOLOGY_FLAG_POS, prevNodeId != null);
Review Comment:
This logic should be moved outside of setter. Setter is used during reading
of message, but in old serde via Java serialization flag wos not set.
It think, it is quite easy to move setting of flag outside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
