Copilot commented on code in PR #7246:
URL: https://github.com/apache/ignite-3/pull/7246#discussion_r2623555678
##########
modules/client/src/test/java/org/apache/ignite/client/TestServer.java:
##########
@@ -200,6 +202,11 @@ public TestServer(
ClientConnectorConfiguration clientConnectorConfiguration = cfg
.getConfiguration(ClientConnectorExtensionConfiguration.KEY).clientConnector();
+ SuggestionsConfiguration suggestionsConfiguration =
mock(SuggestionsConfiguration.class);
+ ConfigurationValue<Boolean> booleanValue =
mock(ConfigurationValue.class);
+ Mockito.when(booleanValue.value()).thenReturn(true);
+
Mockito.when(suggestionsConfiguration.ddlBatchingSuggestionEnabled()).thenReturn(booleanValue);
Review Comment:
The mock is using `ddlBatchingSuggestionEnabled()` but the actual
configuration schema defines the field as `enabled`. This should be
`suggestionsConfiguration.enabled()` to match the production code usage in
ClientHandlerModule line 466.
```suggestion
Mockito.when(suggestionsConfiguration.enabled()).thenReturn(booleanValue);
```
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##########
@@ -174,6 +177,7 @@ public class ClientHandlerModule implements
IgniteComponent, PlatformComputeTran
* @param authenticationManager Authentication manager.
* @param clockService Clock service.
* @param clientConnectorConfiguration Configuration of the connector.
+ * @param suggestionsConfiguration Configuration of system suggestions,
Review Comment:
Missing period at the end of the JavaDoc parameter description. All other
parameter descriptions in this JavaDoc block end with a period.
```suggestion
* @param suggestionsConfiguration Configuration of system suggestions.
```
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -290,6 +294,7 @@ public class ClientInboundMessageHandler
* @param partitionOperationsExecutor Partition operations executor.
* @param features Features.
* @param extensions Extensions.
+ * @param ddlSuggestionEnableConfigdValue Boolean config value indicates
whether the DDL batch processing advice is enabled.
Review Comment:
There is a typo in the parameter name: "ddlSuggestionEnableConfigdValue"
should be "ddlSuggestionEnableConfigValue" (missing 'd' in "Config").
##########
modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/TestServer.java:
##########
@@ -124,6 +126,11 @@ ClientHandlerModule start(TestInfo testInfo) {
ClusterTag clusterTag = ClusterTag.randomClusterTag(msgFactory, "Test
Server");
+ SuggestionsConfiguration suggestionsConfiguration =
mock(SuggestionsConfiguration.class);
+ ConfigurationValue<Boolean> booleanValue =
mock(ConfigurationValue.class);
+ Mockito.when(booleanValue.value()).thenReturn(true);
+
Mockito.when(suggestionsConfiguration.ddlBatchingSuggestionEnabled()).thenReturn(booleanValue);
Review Comment:
The mock is using `ddlBatchingSuggestionEnabled()` but the actual
configuration schema defines the field as `enabled`. This should be
`suggestionsConfiguration.enabled()` to match the production code usage in
ClientHandlerModule line 466.
```suggestion
Mockito.when(suggestionsConfiguration.enabled()).thenReturn(booleanValue);
```
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -310,7 +315,8 @@ public ClientInboundMessageHandler(
BitSet features,
Map<HandshakeExtension, Object> extensions,
Function<String, CompletableFuture<PlatformComputeConnection>>
computeConnectionFunc,
- HandshakeEventLoopSwitcher handshakeEventLoopSwitcher
+ HandshakeEventLoopSwitcher handshakeEventLoopSwitcher,
+ Supplier<Boolean> ddlSuggestionEnableConfigdValue
Review Comment:
There is a typo in the parameter name: "ddlSuggestionEnableConfigdValue"
should be "ddlSuggestionEnableConfigValue" (missing 'd' in "Config").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
