Copilot commented on code in PR #7256:
URL: https://github.com/apache/ignite-3/pull/7256#discussion_r2625104932
##########
modules/platforms/python/scripts/build_wheels.sh:
##########
@@ -19,7 +19,7 @@ set -e -u -x
PACKAGE_NAME="pyignite_dbapi"
PY_VERS=$1
-# Converting input from '3.9,3.10...' to '39 310...'
+# Converting input from '3.10, 3.11...' to '310 311...'
Review Comment:
There's an inconsistency in spacing in the comment. The original comment had
no space after the comma in '3.10,3.11', but this updated version has a space
after the comma '3.10, 3.11'. This differs from other similar comments in the
codebase which don't include a space after the comma (see create_sdist.sh line
22).
```suggestion
# Converting input from '3.10,3.11...' to '310 311...'
```
##########
.github/workflows/python_dbapi_wheels.yml:
##########
@@ -40,46 +42,34 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
- # macos-13 is an intel runner, macos-14 is apple silicon
- os: [ubuntu-22.04, ubuntu-24.04-arm, windows-2022, macos-13, macos-14]
+ include:
+ - os: macos-latest
+ arch: arm64
+ macos_deployment_target: "14.0"
+
+ - os: macos-15-intel
Review Comment:
The runner `macos-15-intel` may not be available in GitHub Actions. The
standard naming for GitHub-hosted runners is `macos-13` for Intel runners and
`macos-14`/`macos-latest` for Apple Silicon. Consider verifying that this
runner label exists in your GitHub Actions environment.
```suggestion
- os: macos-13
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
