tkalkirill commented on code in PR #7247:
URL: https://github.com/apache/ignite-3/pull/7247#discussion_r2625726871
##########
modules/compatibility-tests/src/jobs/java/org/apache/ignite/internal/compute/SendAllMetastorageCommandTypesJob.java:
##########
@@ -67,7 +76,13 @@ private static CompletableFuture<Void>
sendCompactionCommand(MetaStorageManagerI
Method sendCompactionCommand =
metastorage.getClass().getDeclaredMethod("sendCompactionCommand", long.class);
sendCompactionCommand.setAccessible(true);
- return (CompletableFuture<Void>)
sendCompactionCommand.invoke(metastorage, metastorage.appliedRevision());
+ // This is effectively a no-op (applied revision is not 0 at this
point), we are waiting just in case to increase test
+ // robustness.
+ while (metastorage.appliedRevision() == 0) {
Review Comment:
I don't insist, but maybe it would be better to do it asynchronously via
`org.apache.ignite.internal.metastorage.impl.MetaStorageManagerImpl#registerRevisionUpdateListener`.
It's up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
