sashapolo commented on code in PR #7255:
URL: https://github.com/apache/ignite-3/pull/7255#discussion_r2625842749
##########
modules/raft-api/src/main/java/org/apache/ignite/internal/raft/configuration/LogStorageConfigurationSchema.java:
##########
@@ -26,18 +26,42 @@
/** Configuration of the Raft log storage. */
@Config
public class LogStorageConfigurationSchema {
+ public static final int DEFAULT_MAX_CHECKPOINT_QUEUE_SIZE = 10;
+
+ public static final int DEFAULT_SEGMENT_FILE_SIZE_BYTES =
Integer.MAX_VALUE;
+
+ public static final int UNSPECIFIED_MAX_LOG_ENTRY_SIZE = -1;
+
/**
* Maximum size of the log storage checkpoint queue.
*/
@Value(hasDefault = true)
@Range(min = 1)
- public int maxCheckpointQueueSize = 10;
+ public int maxCheckpointQueueSize = DEFAULT_MAX_CHECKPOINT_QUEUE_SIZE;
/**
* Size of a segment file in bytes.
*/
- @SuppressWarnings("PointlessArithmeticExpression") // Suppressed for
better readability.
@Value(hasDefault = true)
- @Range(min = 1 * KiB, max = Integer.MAX_VALUE)
- public long segmentFileSizeBytes = Integer.MAX_VALUE;
+ @Range(min = 4 * KiB, max = Integer.MAX_VALUE)
Review Comment:
Why? We specify a max value here, because it's a `long`, and
`Integer.MAX_VALUE` is an upper bound that may change in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
