ibessonov commented on code in PR #7260:
URL: https://github.com/apache/ignite-3/pull/7260#discussion_r2627087077
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -307,6 +311,8 @@ public boolean isVolatile() {
@Override
public CompletableFuture<Void> startRebalancePartition(int partitionId) {
return busy(() -> mvPartitionStorages.startRebalance(partitionId,
mvPartitionStorage -> {
+ LOG.info("Starting rebalance for partition [tableId={},
partitionId={}]", getTableId(), partitionId);
Review Comment:
Here too
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/incoming/IncomingSnapshotCopier.java:
##########
@@ -218,11 +225,34 @@ public void start() {
}
private CompletableFuture<?>
waitForMetadataWithTimeout(PartitionSnapshotMeta snapshotMeta) {
+ snapshotStats.onWaitingCatalogPhaseStart();
+
+ if (LOG.isInfoEnabled()) {
+ LOG.info(
+ "Waiting for catalog version [snapshotId={}, {},
catalogVersion={}]",
+ snapshotUri.snapshotId,
+ createPartitionInfo(),
+ snapshotMeta.requiredCatalogVersion()
+ );
+ }
+
CompletableFuture<?> metadataReadyFuture =
partitionSnapshotStorage.catalogService()
.catalogReadyFuture(snapshotMeta.requiredCatalogVersion());
CompletableFuture<?> readinessTimeoutFuture =
completeOnMetadataReadinessTimeout();
- return anyOf(metadataReadyFuture, readinessTimeoutFuture);
+ return anyOf(metadataReadyFuture, readinessTimeoutFuture)
+ .whenComplete((ignored, throwable) -> {
+ snapshotStats.onWaitingCatalogPhaseEnd();
+
+ if (LOG.isInfoEnabled()) {
+ LOG.info(
+ "Finished waiting for the catalog readiness
[snapshotId={}, {}, waitingTime={}ms]",
Review Comment:
Let's also write an outcome - was it a timeout or an actual readiness. It
depends on the state of futures in `anyOf`
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java:
##########
@@ -292,6 +296,8 @@ private void busy(Runnable action) {
@Override
public CompletableFuture<Void> startRebalancePartition(int partitionId) {
return busy(() -> mvPartitionStorages.startRebalance(partitionId,
mvPartitionStorage -> {
+ LOG.info("Starting rebalance for partition [tableId={},
partitionId={}]", getTableId(), partitionId);
Review Comment:
Let's also guard it with `if (LOG.isInfoEnabled()) {` just in case, why not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
