rpuch commented on code in PR #7269:
URL: https://github.com/apache/ignite-3/pull/7269#discussion_r2639459705


##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/incoming/IncomingSnapshotCopier.java:
##########
@@ -579,6 +594,7 @@ private CompletableFuture<Void> 
loadSnapshotTxData(InternalClusterNode snapshotS
      */
     private CompletableFuture<Void> completeRebalance(SnapshotContext 
snapshotContext, @Nullable Throwable throwable) {
         snapshotStats.onSnapshotInstallationEnd();
+        snapshotsMetricsSource.onSnapshotInstallationEnd();

Review Comment:
   Also: will this change require the metric names to change? If not, then it's 
ok to leave it this way in any case. If they can be changed, we should be 
careful with making sure that both commits (this one and the one for the commit 
for the TODO) get into the same release.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to