xtern commented on code in PR #7246:
URL: https://github.com/apache/ignite-3/pull/7246#discussion_r2639892128
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -310,7 +315,8 @@ public ClientInboundMessageHandler(
BitSet features,
Map<HandshakeExtension, Object> extensions,
Function<String, CompletableFuture<PlatformComputeConnection>>
computeConnectionFunc,
- HandshakeEventLoopSwitcher handshakeEventLoopSwitcher
+ HandshakeEventLoopSwitcher handshakeEventLoopSwitcher,
+ Supplier<Boolean> ddlBatchingSuggestionEnabled
Review Comment:
Refactored a bit, but it’s not quite the way you would like to see it.
The issue here is:
1. On the one hand, I don't want to pass `DDlBatchingSuggester` directly, as
it's inconvenient for unit tests.
2. On the other hand, I don't want to pass Supplier<Consumer< SqlQueryType
>>. Supplier acts as a factory method, which is needed to create an instance
and is needed so that we create an instance of DDlBatchingSuggester for each
connection. But it's not obvious and looks confusing :pensive:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
