alex-plekhanov commented on code in PR #12339:
URL: https://github.com/apache/ignite/pull/12339#discussion_r2643693926
##########
modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/internal/TcpCommunicationConfigInitializer.java:
##########
@@ -690,6 +690,33 @@ public int getMessageQueueLimit() {
return cfg.messageQueueLimit();
}
+ /**
+ * Sets message queue size to print warning.
+ * <p>
+ * When set to positive number warning will be produced when outgoing
message queue size exeeds provided size.
+ * {@code 0} disables the warning.
+ * <p>
+ * If not provided, default is 0 (do not print warning).
+ *
+ * @param msgQueueWarnSize Outgoing messages queue size to print warning.
+ * @return {@code this} for chaining.
+ */
+ @IgniteSpiConfiguration(optional = true)
+ public TcpCommunicationSpi setMessageQueueWarningSize(int
msgQueueWarnSize) {
Review Comment:
These parameters solve different problems. Queue limit - it's an OOM
protection, warning size - it's an diagnostic. They can be set independently,
for example, queue limit can be 0, while warning size more than 0, so warning
size it's not a factor of queue limit.
About IgniteExperimental - it's just a one parameter for log warning, not an
entire subsystem, I think setting annotation for each minor fix is overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
