sanpwc commented on code in PR #7270:
URL: https://github.com/apache/ignite-3/pull/7270#discussion_r2647131132
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -989,7 +989,7 @@ private CompletableFuture<List<BinaryRow>>
processScanRetrieveBatchAction(ReadWr
TableSchemaAwareIndexStorage indexStorage =
secondaryIndexStorages.get().get(request.indexToUse());
if (indexStorage == null) {
- throw new AssertionError("Index not found: uuid=" +
request.indexToUse());
+ throw new IllegalStateException("Index not found: uuid=" +
request.indexToUse());
Review Comment:
Here and below.
- According to our guidelines we should put all params in square braces
`Index not found [uuid=" + request.indexToUse() +']'` or you may use `
IgniteStringFormatter.format(Index not found [uuid={}]`, request.indexToUse())
- Index id is actually an Integer and not uuid, thus I'd also rename uuid to
just id.
- AFAIC According to our guidelines we should put a full stop at the end of
the exception message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
