sashapolo commented on code in PR #7331:
URL: https://github.com/apache/ignite-3/pull/7331#discussion_r2660929459
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItWriteIntentSwitchRequestHandlerTest.java:
##########
@@ -43,6 +43,17 @@ protected void customizeInitParameters(InitParametersBuilder
builder) {
builder.clusterConfiguration(aggressiveLowWatermarkIncreaseClusterConfig());
}
+ protected static String aggressiveLowWatermarkIncreaseClusterConfig() {
Review Comment:
Can you please rename this method and make it `private`? I don't like that
it clashes with a method from the superclass
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItWriteIntentSwitchRequestHandlerTest.java:
##########
@@ -43,6 +43,17 @@ protected void customizeInitParameters(InitParametersBuilder
builder) {
builder.clusterConfiguration(aggressiveLowWatermarkIncreaseClusterConfig());
}
+ protected static String aggressiveLowWatermarkIncreaseClusterConfig() {
+ return "{\n"
+ + " ignite.gc.lowWatermark {\n"
+ + " dataAvailabilityTimeMillis: 1000,\n"
+ + " updateIntervalMillis: 100\n"
+ + " },\n"
+ // Default 60 seconds, and we need to retry write intent
resolution during test.
Review Comment:
```suggestion
// Default is 60 seconds, and we need to retry write intent
resolution in some tests.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
