PakhomovAlexander commented on code in PR #7356: URL: https://github.com/apache/ignite-3/pull/7356#discussion_r2669938430
########## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/unit/ItNodeUnitStructureCommandTest.java: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.cli.commands.unit; + +import static org.awaitility.Awaitility.await; +import static org.junit.jupiter.api.Assertions.assertAll; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import org.apache.ignite.internal.cli.CliIntegrationTest; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +/** Integration test for node unit structure command. */ +public class ItNodeUnitStructureCommandTest extends CliIntegrationTest { + private static String testFile; + + private static Path testDirectory; + + @BeforeAll + static void beforeAll() throws IOException { + testDirectory = Files.createDirectory(WORK_DIR.resolve("test-structure")); + testFile = Files.createFile(testDirectory.resolve("test.txt")).toString(); + Files.createFile(testDirectory.resolve("test2.txt")); + Files.createFile(testDirectory.resolve("test3.txt")); Review Comment: can u make the test input more diverse? like filenames contains spaces, slashes, dashes, etc? ########## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/unit/ItNodeUnitStructureCommandTest.java: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.cli.commands.unit; + +import static org.awaitility.Awaitility.await; +import static org.junit.jupiter.api.Assertions.assertAll; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import org.apache.ignite.internal.cli.CliIntegrationTest; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +/** Integration test for node unit structure command. */ +public class ItNodeUnitStructureCommandTest extends CliIntegrationTest { Review Comment: Why the test is called `NodeUnit...` but it tests `cluster unit ...`? ########## modules/cli/src/main/java/org/apache/ignite/internal/cli/commands/node/unit/NodeUnitStructureCommand.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.cli.commands.node.unit; + +import static org.apache.ignite.internal.cli.commands.Options.Constants.PLAIN_OPTION; +import static org.apache.ignite.internal.cli.commands.Options.Constants.PLAIN_OPTION_DESC; +import static org.apache.ignite.internal.cli.commands.Options.Constants.UNIT_VERSION_OPTION_DESC; +import static org.apache.ignite.internal.cli.commands.Options.Constants.VERSION_OPTION; + +import jakarta.inject.Inject; +import java.util.concurrent.Callable; +import org.apache.ignite.internal.cli.call.node.unit.NodeUnitStructureCall; +import org.apache.ignite.internal.cli.call.unit.UnitStructureCallInput; +import org.apache.ignite.internal.cli.commands.BaseCommand; +import org.apache.ignite.internal.cli.commands.node.NodeUrlProfileMixin; +import org.apache.ignite.internal.cli.core.call.CallExecutionPipeline; +import org.apache.ignite.internal.cli.core.exception.handler.ClusterNotInitializedExceptionHandler; +import org.apache.ignite.internal.cli.decorators.UnitStructureDecorator; +import picocli.CommandLine.Command; +import picocli.CommandLine.Mixin; +import picocli.CommandLine.Option; +import picocli.CommandLine.Parameters; + +/** Command to show deployment unit structure. */ +@Command(name = "structure", description = "Shows the structure of a deployed unit") Review Comment: I have a concern about the command naming. We tend to name the last command with a verb: `cluster config show`, `cluster unit deploy`, etc. Maybe we can follow this pattern? I would propose `inspect` instead of `structure`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
