Copilot commented on code in PR #7358:
URL: https://github.com/apache/ignite-3/pull/7358#discussion_r2671068594
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/streamer/ItAbstractDataStreamerTest.java:
##########
@@ -958,7 +960,7 @@ public void testReceiverMarshallerMismatch() {
publisher.submit("val1");
}
- var ex = assertThrows(CompletionException.class, () ->
streamerFut.orTimeout(10, TimeUnit.SECONDS).join());
+ var ex = assertThrows(CompletionException.class, () ->
streamerFut.orTimeout(STREAMER_TIMEOUT_SECONDS, TimeUnit.SECONDS).join());
Review Comment:
The timeout for this test has been decreased from 10 seconds to 5 seconds,
which contradicts the PR's purpose of increasing timeouts. This test
(testReceiverMarshallerMismatch) previously had a longer timeout than others,
which may have been intentional. Consider either keeping the original 10-second
timeout or introducing a separate constant for tests that require longer
timeouts.
```suggestion
var ex = assertThrows(CompletionException.class, () ->
streamerFut.orTimeout(10, TimeUnit.SECONDS).join());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
