maksaska commented on code in PR #12555:
URL: https://github.com/apache/ignite/pull/12555#discussion_r2681179691


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceDeploymentTask.java:
##########
@@ -541,6 +541,15 @@ private void completeInitiatingFuture(final Throwable err) 
{
                 }
                 catch (IgniteCheckedException e) {
                     log.error("Failed to unmarshal deployment error.", e);
+
+                    Exception ex = new IgniteCheckedException(
+                        "Failed to unmarshal deployment error! See server logs 
for details."

Review Comment:
   Fixed



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceDeploymentTask.java:
##########
@@ -685,6 +694,19 @@ private void attachDeploymentErrors(@NotNull 
ServiceSingleNodeDeploymentResult d
             }
             catch (IgniteCheckedException e) {
                 log.error("Failed to marshal deployment error, err=" + th, e);
+
+                try {
+                    Exception ex = new IgniteCheckedException(
+                        "Failed to marshal deployment error! See server logs 
for details, err=" + th

Review Comment:
   Fixed



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceDeploymentTask.java:
##########
@@ -685,6 +694,19 @@ private void attachDeploymentErrors(@NotNull 
ServiceSingleNodeDeploymentResult d
             }
             catch (IgniteCheckedException e) {
                 log.error("Failed to marshal deployment error, err=" + th, e);
+
+                try {
+                    Exception ex = new IgniteCheckedException(
+                        "Failed to marshal deployment error! See server logs 
for details, err=" + th
+                    );
+
+                    byte[] arr = U.marshal(ctx, ex);
+
+                    errorsBytes.add(arr);
+                }
+                catch (IgniteCheckedException ex) {
+                    log.error("Failed to attach marshal deployment error to 
the message, err=" + th, ex);

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to