korlov42 commented on code in PR #7355:
URL: https://github.com/apache/ignite-3/pull/7355#discussion_r2681703332
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlToRelConverter.java:
##########
@@ -145,14 +145,50 @@ public SqlNode validateExpression(RelDataType rowType,
SqlNode expr) {
*
* @param node The AST root to convert.
* @param scope The scope to use to resolve column reference, if any.
- * @param inputRowType The input row type. Should be provided if
expression contains any column references.
+ * @param inputRowTypes The types of the input which can be referenced in
the expression.
+ * Should be provided if expression contains any column references.
* @return A converted expression tree.
*/
- public RexNode convertExpressionExt(SqlNode node, SqlValidatorScope scope,
@Nullable RelDataType inputRowType) {
+ public RexNode convertExpressionExt(SqlNode node, SqlValidatorScope scope,
RelDataType... inputRowTypes) {
Review Comment:
initially I thought it doesn't worth the hassle, but turns out setup for the
test is not that bad, hence test has been added. Thanks for highlighting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
