korlov42 commented on code in PR #7324: URL: https://github.com/apache/ignite-3/pull/7324#discussion_r2685289957
########## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/PartitionCountProviderWrapper.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.catalog; + +/** + * Wrapper that allows to apply and use different partition count computing approaches. + */ +public final class PartitionCountProviderWrapper implements PartitionCountProvider { Review Comment: the only rationale behind this wrapper's existing is to break circular dependency. `CatalogManager` expects `PartitionCountProvider` in its constructor. It will be happy to work with any implementation. On the other hand, future `PartitionCountProviderImpl` most likely will have dependency on `DistributionZoneManager` which, it turn, expects `CatalogManager` in its constructor. Each component alone doesn't actually need this wrapper. But this wrapper is required to properly create all these objects, and this is responsibility of `IgniteImpl`. This is why I think `runner` is the best option -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
