alievmirza commented on code in PR #7395:
URL: https://github.com/apache/ignite-3/pull/7395#discussion_r2689507473
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -802,9 +803,21 @@ public void resetPeers(ReplicationGroupId replicaGrpId,
PeersAndLearners peersAn
Loza loza = (Loza) raftManager;
Status status = loza.resetPeers(raftNodeId, peersAndLearners,
sequenceToken);
- // Stale configuration change will not be retried.
- if (!status.isOk() && status.getRaftError() == RaftError.ESTALE) {
- throw new IgniteException(INTERNAL_ERR, new
RaftStaleUpdateException(status.getErrorMsg()));
+ if (!status.isOk()) {
+ RaftError error = status.getRaftError();
+
+ // Stale configuration change will not be retried.
+ if (error == RaftError.ESTALE) {
+ throw new IgniteException(INTERNAL_ERR, new
RaftStaleUpdateException(status.getErrorMsg()));
+ }
+
+ // EBUSY means there's an ongoing configuration change -
retriable, will eventually complete.
+ if (error == RaftError.EBUSY) {
+ throw new IgniteException(INTERNAL_ERR, "Configuration change
in progress, will retry: " + status);
+ }
+
+ // EPERM (node not active) and EINVAL (invalid args) are not
retriable.
Review Comment:
What about all other Raft errors, like `ENOENT`, `EINTERNAL` and other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
