Phillippko commented on code in PR #7407:
URL: https://github.com/apache/ignite-3/pull/7407#discussion_r2689507320
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1655,7 +1657,7 @@ private PartitionUpdateHandlers
createPartitionUpdateHandlers(
replicationConfiguration,
modificationCounter
);
- storageUpdateHandler.start();
+ storageUpdateHandler.start(onNodeRecovery);
Review Comment:
let's use one term? Start or recovery
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/StorageUpdateHandler.java:
##########
@@ -108,8 +108,10 @@ public int partitionId() {
/**
* Starts the handler doing necessary recovery.
Review Comment:
Let's update javadoc? State that we do recovery if node starts. Or remove at
all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
