korlov42 commented on code in PR #7399:
URL: https://github.com/apache/ignite-3/pull/7399#discussion_r2689313015
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/logical/IgniteJoinConditionPushRule.java:
##########
@@ -33,6 +33,11 @@
*/
@Value.Enclosing
public class IgniteJoinConditionPushRule extends
FilterJoinRule<IgniteJoinConditionPushRuleConfig> {
+ // This constant is chosen empirically. If set to 32, then TPC-H q19 will
result in less optimal plan
+ // involving NestedLoopJoin instead of HashJoin. If set to 128, then
planning of TPC-DS q41 will take
+ // more than 40sec and might even fail with OOM (depending on amount of
mem available on machine).
+ private static final int MAX_CNF_NODE_COUNT = 64;
Review Comment:
I don't think so. We might tweak this constant later in future releases, but
I cannot think of the reason to expose it as any sort of configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
