EgorKuts commented on code in PR #7350:
URL: https://github.com/apache/ignite-3/pull/7350#discussion_r2694101939
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/exporters/log/LogPushExporter.java:
##########
@@ -42,13 +46,21 @@
public class LogPushExporter extends PushMetricExporter {
public static final String EXPORTER_NAME = "logPush";
- /** Padding for individual metric output. */
+ /** Padding for individual metric output in multiline mode. */
Review Comment:
fixed
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/exporters/log/LogPushExporter.java:
##########
@@ -71,54 +83,373 @@ public void report() {
return;
}
- var report = new StringBuilder("Metric report:");
+ var report = new StringBuilder("Metrics for local node: ");
+
+ appendNodeInfo(report, metricSets);
+
+ boolean initialized = isNodeInitialized(metricSets);
+ report.append(", state=").append(initialized ? "initialized" :
"uninitialized");
+
+ UUID clusterId = clusterIdSupplier().get();
+ if (clusterId != null) {
+ report.append(", clusterId=").append(clusterId);
+ }
+
+ int nodeCount = getClusterNodeCount(metricSets);
+ if (nodeCount > 0) {
+ report.append(", topology=").append(nodeCount).append(" nodes");
+ }
+
+ appendNetworkInfo(report, metricSets);
+
+ appendCpuInfo(report, metricSets);
+
+ appendHeapInfo(report, metricSets);
for (MetricSet metricSet : metricSets) {
boolean hasMetricsWhiteList = hasMetricsWhiteList(metricSet);
if (hasMetricsWhiteList || metricEnabled(metricSet.name())) {
-
report.append('\n').append(metricSet.name()).append(oneLinePerMetricSource ? '
' : ':');
-
- appendMetrics(report, metricSet, hasMetricsWhiteList);
+ if (oneLinePerMetricSource) {
+ report.append(", ").append(metricSet.name()).append('=');
+ appendMetricsOneLine(report, metricSet,
hasMetricsWhiteList);
+ } else {
+ report.append('\n').append(metricSet.name()).append(':');
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
